Here's what I found 🙂

EuiEmptyPrompt’s Guidelines subpage

• in the "Empty state types, goals, and recommendations" section, some styles like the sidebar look different, also the template radio buttons seem overflowed [screenshot 1]
• image comparisons don't have the same height, and in some cases the blueish background is missing (not sure if intended) [screenshot 2]
• [not part of the changes] the "empty prompt usage guidelines" link in the Overview page that links to the Guidelines page is broken

[1]

[2]

Old	New

EuiToast’s Guidelines subpage

• in the examples, the "danger" button has a larger font size in all instances [screenshot 3]
• [not part of the changes] the "toast usage guidelines" link in the Overview page that links to the Guidelines page is broken

[3]

Old	New

EuiTour’s Guidelines subpage

No comments 👍

Form controls’ Guidelines subpage

• the comparison do/dont snippets don't have the same height, maybe it's intended but I think it looks better on the old site
• in "Hint text" and "Placeholder text/In fields" sections there's a dont that should be do [screenshot 4]

[4]

Old	New

Selection controls’ Guidelines subpage

• styles in the "Switch labels" do/dont section are strange [screenshot 5]

[5]

Old	New

I fixed whatever I could, some things I couldn't without going outside of the scope of this PR and I'd propose to fix them on another task 😄

EuiEmptyPrompt ❌

This one... 💀 With a bit of styling I managed to fix the "image radios" (5b34e63). The preview I was not able to get it to work as expected, hence #8312. Do you have an idea how to fix it?

I updated the link 👍🏻 (9052665)

EuiToast ✅

This one is super weird! 🤔 The danger buttons do have bigger font-size although the same size is passed. If you take a look at the Button page, it displays as expected there.

There are no additional styles passed to them. Something must be influencing it from higher up? Do you have an idea what could be wrong?

EDIT: @acstll found out that the issue is with Docusaurus applying paragraph styles to a text that is in newline. I created a ticket in M2 to come up with a meaningful fix for this: #8329

I updated the link 👍🏻 (0f0ae20)

Form controls ✅

I made the height of guideline panels equal and I changed some (incorrect) "don't" sections to "do" (925a1e4):

Selection controls ✅

I agree this table looks weird 👍🏻 What I found is that this is the responsive behavior of EuiBasicTable. The width of the page content is smaller than in the original docs, causing the table to pass a breakpoint and display like this. When I applied responsiveBreakpoint={false} it looks as in the original docs (8284ce5). I'm sure it's fine to get rid of the responsive behavior because it doesn't serve the purpose of this guideline specifically.

The code in: packages/website/docs/components/forms/selection_controls/guidelines.mdx is the same as in: packages/eui/src-docs/src/views/selection_controls/guidelines.js.

I fixed whatever I could, some things I couldn't without going outside of the scope of this PR and I'd propose to fix them on another task 😄

@weronikaolejniczak I agree we could fix these later on 👍

I'll take a quick look first at your comments for EuiEmptyPrompt and EuiToast first, and then re-run this locally for a final check 🤓

(btw the screenshots inside the <details> toggles are not rendering… maybe there's a space missing somewhere? putting markdown inside html does not always work, but I'm not sure that's the case…)

@acstll ohhh, thanks for letting me know! 🙏🏻 I uploaded the screenshots first, put them into details and didn't bother to check if it works. Fixed by just using img. 🗒️ ✏️

Preview staging links for this PR:

• Docs site: https://eui.elastic.co/pr_8309/
• Storybook: https://eui.elastic.co/pr_8309/storybook
• New docs: https://eui.elastic.co/pr_8309/new-docs

💚 Build Succeeded

• Buildkite Build
• Commit: 8815898

History

• 💚 Build elastic/eui#3459 succeeded 7808a49
• 💚 Build elastic/eui#3455 succeeded f67b4d3
• 💚 Build elastic/eui#3435 succeeded 208b739
• 💔 Build elastic/eui#3434 failed 5b34e63
• 💚 Build elastic/eui#3419 succeeded 2bc584d

cc @weronikaolejniczak